Back during the Linux 6.18 merge window Linus Torvalds commented on “mindless and completely crazy Rust format checking” and that the RUst format checking “is all bass-ackwards garbage” with condensing multi-line import statements into single lines. Merged minutes ago to Linux Git ahead of tomorrow’s Linux 6.18-rc2 are fixes to the Rust format checking and updated guidelines to address Torvalds’ criticism.
Rust for Linux lead developer Miguel Ojeda commented with today’s Rust for Linux 6.18 updates that have been merged:
“Rust ‘rustfmt’ cleanup
‘rustfmt’, by default, formats imports in a way that is prone to conflicts while merging and rebasing, since in some cases it condenses several items into the same line.
Document in our guidelines that we will handle this for the moment with the trailing empty comment workaround and make the tree ‘rustfmt’-clean again”
The rustfmt update and updated guidance in the documentation should address the criticism raised by Torvalds back during the Linux 6.18 merge window to make the Rust code smoother moving forward:
Look for this clean-up in tomorrow’s Linux 6.18-rc2 release.